Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.mdを修正 #1129

Merged
merged 3 commits into from
Jan 19, 2023
Merged

README.mdを修正 #1129

merged 3 commits into from
Jan 19, 2023

Conversation

kat0h
Copy link
Contributor

@kat0h kat0h commented Jan 19, 2023

内容

README.mdの実行の章について、macOS/Linux環境の場合実行方法が少々わかりにくかったため、説明を追加しました。
確認いただければ幸いです。

関連 Issue

なし

スクリーンショット・動画など

その他

@kat0h kat0h requested a review from a team as a code owner January 19, 2023 12:32
@kat0h kat0h requested review from Hiroshiba and removed request for a team January 19, 2023 12:32
y-chan
y-chan approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！

Hiroshiba
Hiroshiba reviewed Jan 19, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

READMEは結構古くなっているところがあると思います、また見つけたら気軽に修正送って頂けると嬉しいです！！

@Hiroshiba Hiroshiba merged commit 943436e into VOICEVOX:main Jan 19, 2023
@kat0h
Copy link
Contributor Author

kat0h commented Jan 19, 2023

確認ありがとうございます！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@y-chan y-chan y-chan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kat0h @Hiroshiba @y-chan