Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: x86_64-linux-androidを追加 #13

Merged
merged 7 commits into from
Apr 23, 2023
Merged

Add: x86_64-linux-androidを追加 #13

merged 7 commits into from
Apr 23, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

タイトル通り。

関連 Issue

（なし）

スクリーンショット・動画など

（なし）

その他

（なし）

Hiroshiba
Hiroshiba reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらも手順がないので正確なことがわからないのですが、たぶん必要そうだろうなと思うのをコメントしてみます！

を見た感じ、

.cargo/config.toml
.github/actions/auto_gen_bind_pr/action.yml
.github/workflows/gen_bind.yml
.github/workflows/test.yml

辺りに変更があった方が正確な気がしました！

あとこちらもサンプルとして有用そうですが、変更ファイルは同じ感じでした。

@sevenc-nanashi sevenc-nanashi mentioned this pull request Apr 20, 2023
Open
qryxip
qryxip approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PickledChair
PickledChair approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@PickledChair PickledChair merged commit d766a52 into VOICEVOX:main Apr 23, 2023
@sevenc-nanashi sevenc-nanashi mentioned this pull request Jun 8, 2023
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba left review comments

@qryxip qryxip qryxip approved these changes

@PickledChair PickledChair PickledChair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sevenc-nanashi @Hiroshiba @qryxip @PickledChair