Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iOS以外CMAKE_SYSTEM_PROCESSORを指定 #61

Merged

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 28, 2024

内容

追記: #61 (comment)

関連 Issue

Refs: VOICEVOX/voicevox_core#888 (comment)

スクリーンショット・動画など

その他

@qryxip
Copy link
Member Author

qryxip commented Dec 28, 2024

@qryxip qryxip requested a review from Hiroshiba December 28, 2024 14:20
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なぜarm64指定でうまく行くはずなのかちょっとわかってないけど、LGTM!!

@qryxip
Copy link
Member Author

qryxip commented Dec 29, 2024

VOICEVOX/voicevox_core#888 としては駄目だったっぽい。

https://github.com/qryxip/voicevox_core/actions/runs/12528283080

それがわかったところでこのPRをどうするかですが、多分新しいONNX Runtimeだと本PRのようなことをせずともなんとかなってそうなんですよね…

@qryxip
Copy link
Member Author

qryxip commented Dec 29, 2024

いや @sevenc-nanashi さんのこれを見る限り新しいONNX Runtimeにはどちらにせよ必須になるっぽいな。なのでこのPRはこのPRでマージしたほうがよさそう。
https://github.com/sevenc-nanashi/onnxruntime-builder/actions/runs/12461866078

@qryxip qryxip merged commit 5131d1d into VOICEVOX:main Dec 29, 2024
2 checks passed
@qryxip qryxip deleted the fix-specify-cmake-system-processor-except-for-ios branch December 29, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants