feat: Improve FrozenVideo and VideoDecoderCPU detectors#32
Merged
Conversation
…-issue-detector into decoder-issue-detector
…-issue-detector into decoder-issue-detector
evgmel
reviewed
Jan 17, 2025
Contributor
|
🎉 This PR is included in version 1.14.0-debug-detectors.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
eugeny-dementev
approved these changes
Jan 20, 2025
Contributor
|
🎉 This PR is included in version 1.14.0-improve-base-detectors.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
evgmel
approved these changes
Jan 22, 2025
Collaborator
evgmel
left a comment
evgmel
left a comment
There was a problem hiding this comment.
Great job! Thanks for the improvements 🤝
…-issue-detector into improve-base-detectors
Contributor
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created new
VideoDecoderIssueDetectorthat detects decoder CPU throttling in a better way thanFramesDroppedIssueDetectorImproved
FrozenVideoTrackDetectorthat uses basic video freeze metrics from getStats()False positive results based on bad network circumstances are filtered out by additional check in
VideoDecoderIssueDetectorandFrozenVideoTrackDetectorDeleted
FramesEncodedSentIssueDetectordue to redundancy in network problem detection.QualityLimitationsIssueDetectorandOutboundNetworkIssueDetectorgive better results.