Small unrelated improvements #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrDet
force-pushed
the
dvaksman/runtime-improvements
branch
from
efe9ab0
to
ae44f7c
Compare
DrDet
force-pushed
the
dvaksman/runtime-improvements
branch
from
7ad4e68
to
2d4cb8d
Compare
astrophysik
approved these changes
Nov 3, 2023
troy4eg
approved these changes
Nov 3, 2023
astrophysik
pushed a commit
that referenced
this pull request
Nov 9, 2023
- don't fetch net events right before script termination (relates to #893) - added total allocation metrics: `kphp_memory_script_allocated_total`, `kphp_memory_script_allocations_count` - removed maximum script timeout limit - make `disable-sql` option deprecated and turned on unless SQL port is given
astrophysik
pushed a commit
that referenced
this pull request
Nov 9, 2023
This reverts commit 2aa574b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kphp_memory_script_allocated_total,kphp_memory_script_allocations_countdisable-sqloption deprecated and turned on unless SQL port is given