add fork support in runtime light #1029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolyakov
requested changes
Jul 3, 2024
apolyakov
reviewed
Jul 4, 2024
apolyakov
previously approved these changes
Jul 5, 2024
astrophysik
force-pushed
the
vsadokhov/fork-light-support
branch
from
58b5083
to
29c4d07
Compare
astrophysik
force-pushed
the
vsadokhov/fork-light-support
branch
from
101e17e
to
245e44c
Compare
apolyakov
requested changes
Jul 10, 2024
apolyakov
requested changes
Jul 12, 2024
apolyakov
requested changes
Jul 16, 2024
| timer_d = arg.timeout_d; | ||
| } else if constexpr (std::is_same_v<T, stream_future>) { | ||
| timer_d = arg.timeout_d; | ||
| } else { |
There was a problem hiding this comment.
Let's also add static_assert(false, "non-exhaustive visitor!"); here
apolyakov
reviewed
Jul 17, 2024
| }; | ||
|
|
||
| template<typename T> | ||
| using internal_optional_type = typename InternalOptionalType<T>::type; |
There was a problem hiding this comment.
Let's name it internal_optional_type_t in a manner that standard lib names such traits
astrophysik
force-pushed
the
vsadokhov/fork-light-support
branch
2 times, most recently
from
0708bb6
to
2071f5e
Compare
astrophysik
force-pushed
the
vsadokhov/fork-light-support
branch
from
2071f5e
to
614792f
Compare
DrDet
reviewed
Jul 17, 2024
|
|
||
| static KphpForkContext &get(); | ||
|
|
||
| KphpForkContext(memory_resource::unsynchronized_pool_resource &memory_pool) |
There was a problem hiding this comment.
Suggested change
| KphpForkContext(memory_resource::unsynchronized_pool_resource &memory_pool) | |
| explicit KphpForkContext(memory_resource::unsynchronized_pool_resource &memory_pool) |
Comment on lines
+159
to
+160
| running_forks[fork_id] = light_fork(std::move(task)); | ||
| running_forks[fork_id].resume(fork_id); |
There was a problem hiding this comment.
maybe we'll get rid of double lookup?
| template<typename T> | ||
| using deque = memory_resource::stl::deque<T, memory_resource::unsynchronized_pool_resource>; | ||
|
|
||
| fork_scheduler(memory_resource::unsynchronized_pool_resource &memory_pool) |
There was a problem hiding this comment.
Suggested change
| fork_scheduler(memory_resource::unsynchronized_pool_resource &memory_pool) | |
| explicit fork_scheduler(memory_resource::unsynchronized_pool_resource &memory_pool) |
and check out other similar places pls
| if (func->has_global_vars_inside) { | ||
| W << PhpMutableGlobalsAssignCurrent() << NL; | ||
| } | ||
| W << "vk::final_action action([]{KphpForkContext::get().scheduler.mark_current_fork_as_ready();});" << NL; |
There was a problem hiding this comment.
Let's recheck that it's working in case when current function is called from other fork. It's a bit strange that we change codegen of function we want to fork. It should be redundant when we use C++-20 coroutines.
There was a problem hiding this comment.
I think it's better to determine that fork is ready outside of its logic, i.e. somewhere in scheduler
Comment on lines
+1468
to
+1490
| if (func->kphp_tracing) { | ||
| TracingAutogen::codegen_runtime_func_guard_declaration(W, func); | ||
| TracingAutogen::codegen_runtime_func_guard_start(W, func); | ||
| } | ||
| compile_tracing_profiler(func, W); | ||
|
|
||
| for (auto var : func->local_var_ids) { | ||
| if (var->type() != VarData::var_local_inplace_t && !var->is_foreach_reference) { | ||
| W << VarDeclaration(var); | ||
| } | ||
| } | ||
|
|
||
| if (func->has_variadic_param) { | ||
| auto params = func->get_params(); | ||
| kphp_assert(!params.empty()); | ||
| auto variadic_arg = std::prev(params.end()); | ||
| auto name_of_variadic_param = VarName(variadic_arg->as<op_func_param>()->var()->var_id); | ||
| W << "if (!" << name_of_variadic_param << ".is_vector())" << BEGIN; | ||
| W << "php_warning(\"pass associative array(" << name_of_variadic_param << ") to variadic function: " << FunctionName(func) << "\");" << NL; | ||
| W << name_of_variadic_param << " = f$array_values(" << name_of_variadic_param << ");" << NL; | ||
| W << END << NL; | ||
| } | ||
| W << AsSeq{func_root->cmd()} << END << NL; |
There was a problem hiding this comment.
Also let's recheck that it's actually needed in our case
| // Distributed under the GPL v3 License, see LICENSE.notice.txt | ||
|
|
||
| #pragma once | ||
|
|
There was a problem hiding this comment.
let's add midding includes like coroutine, type_traits etc.
Comment on lines
+67
to
+77
| unordered_set<int64_t> ready_forks; | ||
| /* map from runtime_future {stream_future, fork_future} to waiting fork*/ | ||
| unordered_map<runtime_future, int64_t> future_to_blocked_fork; | ||
| /* reverse of future_to_blocked_fork */ | ||
| unordered_map<int64_t, runtime_future> fork_to_awaited_future; | ||
| /* timeout timer_d to waiting fork */ | ||
| unordered_map<uint64_t, int64_t> timer_to_blocked_fork; | ||
| /* set of forks that wait to accept incoming stream */ | ||
| unordered_set<int64_t> wait_incoming_query_forks; | ||
|
|
||
| deque<int64_t> forks_ready_to_resume; |
There was a problem hiding this comment.
I suggest to add detailed comment about typical fork lifecycle and its transitions between these hash tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork support in runtime light
This pr add
forkandwaitfunctions in runtime light. The main difference from forks in the master is the use of C++20 coroutinesOveriew
The class that stores the current state of the forks is
KphpForkContext. It containsfork_scheduler, which is responsible for executing forks. In the schedule function it tries to execute all possible coroutines, if the main fork runs out or there are no forks available for execution the component is blocked.The fork stored in the
light_forkclass. It stores a pointer to the first coroutine frame and the last interrupt point. Thefork_resulttype erasue class is used to store the result.