-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TokensClassProvider): circular dependency #8354
fix(TokensClassProvider): circular dependency #8354
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8354 +/- ##
==========================================
- Coverage 95.45% 95.44% -0.01%
==========================================
Files 409 408 -1
Lines 11629 11626 -3
Branches 3849 3849
==========================================
- Hits 11100 11097 -3
Misses 529 529
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
👀 Docs deployed
Commit 24868ae |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
✅ v7.2.0 🎉 |
Описание
Воиспроизведение https://github.com/VKCOM/devicehub/tree/c3ac1c4/ui
Проверил с помощью madge, там действительно есть циклические зависимости
Изменения
Удаляем index.ts, для реализации инкапсуляции в отдельных модулях нужно использовать другой подход с использованием линтеров и специальных папок
Release notes
Исправления