Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popover, OnboardingTooltip): add prop disableFocusTrap #8322

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Release notes

Описание

Для pr #8291 нужно добавить свойство disableFocusTrap для компонентов Popover и OnboardingTooltip, чтобы отключить захват фокуса

Release notes

Улучшения

  • Popover: Добавлено свойство disableFocusTrap для отключения захвата фокуса
  • OnboardingTooltip: Добавлено свойство disableFocusTrap для отключения захвата фокуса

@EldarMuhamethanov EldarMuhamethanov added type:feature cmp:popover Бывший dropdown cmp:onboarding-tooltip https://vkcom.github.io/VKUI/#/OnboardingTooltip labels Mar 3, 2025
@EldarMuhamethanov EldarMuhamethanov added this to the v7.2.0 milestone Mar 3, 2025
@EldarMuhamethanov EldarMuhamethanov self-assigned this Mar 3, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner March 3, 2025 08:13
Copy link
Contributor

github-actions bot commented Mar 3, 2025

size-limit report 📦

Path Size
JS 396.45 KB (+0.03% 🔺)
JS (gzip) 120.41 KB (+0.03% 🔺)
JS (brotli) 98.96 KB (-0.06% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.65 KB (0%)
CSS (gzip) 43.17 KB (0%)
CSS (brotli) 34.43 KB (0%)

Copy link

codesandbox-ci bot commented Mar 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Mar 3, 2025

👀 Docs deployed

Commit 328e842

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (ca11ef6) to head (328e842).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8322   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         406      406           
  Lines       11610    11611    +1     
  Branches     3844     3845    +1     
=======================================
+ Hits        11083    11084    +1     
  Misses        527      527           
Flag Coverage Δ
unittests 95.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit f8d30b2 into master Mar 5, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/add-popovers-focus-trap-disabled branch March 5, 2025 07:48
@vkcom-publisher
Copy link
Contributor

v7.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:onboarding-tooltip https://vkcom.github.io/VKUI/#/OnboardingTooltip cmp:popover Бывший dropdown type:feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants