Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Alert): add testid for title and description #8298

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

BlackySoul
Copy link
Contributor

  • Unit-тесты
  • Документация фичи
  • Release notes

Описание

Добавляем data-testid для title и description

Release notes

Пример:

Улучшения

  • Alert: добавлены data-testid для title (titleTestId) и description (descriptionTestId)

@BlackySoul BlackySoul added this to the v7.2.0 milestone Feb 19, 2025
@BlackySoul BlackySoul self-assigned this Feb 19, 2025
@BlackySoul BlackySoul requested a review from a team as a code owner February 19, 2025 16:04
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 397.03 KB (+0.03% 🔺)
JS (gzip) 120.61 KB (+0.04% 🔺)
JS (brotli) 99.12 KB (-0.07% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.63 KB (0%)
CSS (gzip) 43.16 KB (0%)
CSS (brotli) 34.51 KB (0%)

Copy link
Contributor

e2e tests

Playwright Report

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (17103ad) to head (5aeb39a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8298   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files         404      404           
  Lines       11640    11640           
  Branches     3857     3857           
=======================================
  Hits        11121    11121           
  Misses        519      519           
Flag Coverage Δ
unittests 95.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👀 Docs deployed

Commit 5aeb39a

@BlackySoul BlackySoul merged commit 2c22d99 into master Feb 20, 2025
29 checks passed
@BlackySoul BlackySoul deleted the BlackySoul-patch-1 branch February 20, 2025 06:06
@vkcom-publisher
Copy link
Contributor

v7.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants