Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cell): enlarge dragger area #8288

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

EldarMuhamethanov
Copy link
Contributor


  • e2e-тесты
  • Release notes

Описание

Нужно увеличить размер dragger в Cell.

Изменения

  • Сделал так, чтобы dragger по высоте растягивался на всю высоту Cell
  • Вместо margin у dragger сделал padding, чтобы это была активная для drag зона

Release notes

Улучшения

  • Cell: Увеличена автивная область действия контрола для Drag And Drop

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner February 17, 2025 08:49
Copy link
Contributor

size-limit report 📦

Path Size
JS 397.06 KB (0%)
JS (gzip) 120.59 KB (0%)
JS (brotli) 99.13 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.58 KB (+0.07% 🔺)
CSS (gzip) 43.16 KB (+0.06% 🔺)
CSS (brotli) 34.47 KB (+0.07% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 51b3a5e

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (a800843) to head (51b3a5e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8288   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files         404      404           
  Lines       11641    11641           
  Branches     3859     3859           
=======================================
  Hits        11122    11122           
  Misses        519      519           
Flag Coverage Δ
unittests 95.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Шикарно, спасибо!

@EldarMuhamethanov EldarMuhamethanov merged commit 079246d into master Feb 17, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8229/enlarge-dragger-area branch February 17, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Cell]: увеличить draggable зону
3 participants