feat(Progress): add custom color prop and trackDisable prop. #8167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit 13f56be |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8167 +/- ##
=======================================
Coverage 95.49% 95.50%
=======================================
Files 403 403
Lines 11456 11468 +12
Branches 3781 3787 +6
=======================================
+ Hits 10940 10952 +12
Misses 516 516
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # packages/vkui/src/components/Progress/__image_snapshots__/progress-android-chromium-dark-1-snap.png # packages/vkui/src/components/Progress/__image_snapshots__/progress-android-chromium-light-1-snap.png # packages/vkui/src/components/Progress/__image_snapshots__/progress-ios-webkit-dark-1-snap.png # packages/vkui/src/components/Progress/__image_snapshots__/progress-ios-webkit-light-1-snap.png # packages/vkui/src/components/Progress/__image_snapshots__/progress-vkcom-chromium-dark-1-snap.png # packages/vkui/src/components/Progress/__image_snapshots__/progress-vkcom-chromium-light-1-snap.png # packages/vkui/src/components/Progress/__image_snapshots__/progress-vkcom-firefox-dark-1-snap.png # packages/vkui/src/components/Progress/__image_snapshots__/progress-vkcom-firefox-light-1-snap.png # packages/vkui/src/components/Progress/__image_snapshots__/progress-vkcom-webkit-dark-1-snap.png # packages/vkui/src/components/Progress/__image_snapshots__/progress-vkcom-webkit-light-1-snap.png
inomdzhon
reviewed
Jan 21, 2025
inomdzhon
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
color, которое позволяет установить кастомный цвет для полоски. Работает приappearance="custom"trackDisableдля того, чтобы сделать фон прогрессбара прозрачнымRelease notes
Улучшения
colorдля установки кастомного цвета полоскиtrackDisableдля того, чтобы сделать фон прогрессбара прозрачным