a11y(CardScroll): fix a11y, ul>li combination #8140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8140 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 403 403
Lines 11503 11505 +2
Branches 3812 3812
=======================================
+ Hits 10985 10987 +2
Misses 518 518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit 4cc1e54 |
andrey-medvedev-vk
previously approved these changes
Jan 10, 2025
vkcom-publisher
added
the
pr-needs-work
inomdzhon
reviewed
Jan 23, 2025
packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx
Outdated
Show resolved
Hide resolved
vkcom-publisher
removed
the
pr-needs-work
# Conflicts: # packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx
andrey-medvedev-vk
previously approved these changes
Jan 27, 2025
andrey-medvedev-vk
previously approved these changes
Jan 27, 2025
inomdzhon
previously approved these changes
Jan 28, 2025
…/fix-card-scroll-a11y # Conflicts: # packages/vkui/src/components/CardScroll/CardScroll.test.tsx
EldarMuhamethanov
dismissed stale reviews from inomdzhon and andrey-medvedev-vk
via
4cc1e54
andrey-medvedev-vk
approved these changes
Jan 28, 2025
inomdzhon
approved these changes
Jan 28, 2025
EldarMuhamethanov
deleted the
e.muhamethanov/8135/fix-card-scroll-a11y
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ulтег по умолчанию нарушает семантику ul>li #8135Описание
Сейчас в компоненте
CardScrollесть проблема с доступностью. Карточкиliне являются прямыми потомкамиul. Нужно придумать как решить эту проблемуИзменения
Componentс 'ul' на 'div'(как было раньше). Почему это не breaking change? Потому что по идее это баг, текущее поведение все равно не работало как задумывалосьCardsListComponent, которое позволяет поменять тег используемый для списка карточек. Значение по умолчанию"ul"CardsScroll, чтобы уменьшить количество нод DOM дерева. Сделал падинги по бокам через псевдоэлементыafter/before.HorizontalScrollдобавил свойстваContentWrapperComponent,contentWrapperRefиcontentWrapperClassNameдля кастомизации обертки над контентом, прокинутом вchildren. Это было сделано, чтобы вCardsScrollи других возможных местах не создавать доп обертку над контентом и уменьшить количество нод.a11y- теперь они проходятRelease notes
Улучшения
ContentWrapperComponent,contentWrapperRefиcontentWrapperClassNameдля кастомизации обертки над контентом, прокинутом вchildrenCardsListComponent, которое позволяет поменять тег используемый для списка карточекИсправления
li(карточки) являются прямыми потомкамиul(списка карточек)Componentс"ul", на"div". Для правильно семантики тегов нужно использовать свойствоCardsListComponent, которое по умолчанию теперь"ul"