Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PanelHeaderBack): fix rtl view #8129

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

EldarMuhamethanov
Copy link
Contributor

  • e2e-тесты
  • Release notes

Описание

Сейчас иконки "Назад" в пресете PanelHeaderBack отображается некорректно в rtl.

Изменения

Добавил отзеркаливание иконок "Назад" в пресете PanelHeaderBack при rtl режиме.

Release notes

Улучшения

  • PanelHeaderButton: Поправлено отображение прессета PanelHeaderBack в rtl режиме

@EldarMuhamethanov EldarMuhamethanov added this to the v7.2.0 milestone Dec 27, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Dec 27, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 27, 2024 11:46
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 27, 2024
@EldarMuhamethanov EldarMuhamethanov removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 27, 2024
@EldarMuhamethanov EldarMuhamethanov changed the title fix(PanelHeaderBack): fix rtl view feat(PanelHeaderBack): fix rtl view Dec 27, 2024
Copy link
Contributor

github-actions bot commented Dec 27, 2024

size-limit report 📦

Path Size
JS 389.61 KB (+0.03% 🔺)
JS (gzip) 118.25 KB (+0.03% 🔺)
JS (brotli) 97.39 KB (+0.07% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 342.66 KB (+0.02% 🔺)
CSS (gzip) 42.47 KB (+0.05% 🔺)
CSS (brotli) 33.84 KB (+0.05% 🔺)

Copy link

codesandbox-ci bot commented Dec 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (ba6b9c4) to head (0cfb7e5).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8129   +/-   ##
=======================================
  Coverage   95.55%   95.56%           
=======================================
  Files         398      398           
  Lines       11351    11360    +9     
  Branches     3741     3744    +3     
=======================================
+ Hits        10847    10856    +9     
  Misses        504      504           
Flag Coverage Δ
unittests 95.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

👀 Docs deployed

Commit 0cfb7e5

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 5, 2025
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 10, 2025
@EldarMuhamethanov EldarMuhamethanov merged commit 0c33d7d into master Jan 15, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/rtl/PanelHeaderBack branch January 15, 2025 09:13
@vkcom-publisher
Copy link
Contributor

v7.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants