Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Search): fix rtl view #8105

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

  • e2e-тесты
  • Release notes

Описание

Сейчас в компоненте Search кнопка очистки некорректно отображается в rtl

Изменения

Доработаны стили компонента Search в режиме rtl

Release notes

Улучшения

  • Search: Добавлена поддержка компонента в rtl

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 389.05 KB (+0.02% 🔺)
JS (gzip) 118.07 KB (+0.03% 🔺)
JS (brotli) 97.18 KB (+0.01% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 341.72 KB (+0.07% 🔺)
CSS (gzip) 42.32 KB (+0.08% 🔺)
CSS (brotli) 33.7 KB (-0.06% 🔽)

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.55%. Comparing base (b5f950e) to head (ba25423).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8105   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         398      398           
  Lines       11326    11331    +5     
  Branches     3731     3733    +2     
=======================================
+ Hits        10822    10827    +5     
  Misses        504      504           
Flag Coverage Δ
unittests 95.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit ba25423

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 26, 2024
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 28, 2024
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Прекрасно! 🔥

@EldarMuhamethanov EldarMuhamethanov merged commit 6e9f9a9 into master Dec 28, 2024
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/rtl/Search branch December 28, 2024 14:39
@vkcom-publisher
Copy link
Contributor

v7.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants