Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Slider): fix rtl view #8098

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас компонент Slider некорректно отображается в rtl режиме. Нужно доработать логику отображения

Изменения

  • Доработал логику отображения в компоненте Slider в режиме rtl
  • Добавил тесты и скриншоты в rtl режиме

Release notes

Улучшения

  • Slider: Добавлена поддержка rtl

Copy link
Contributor

size-limit report 📦

Path Size
JS 389.11 KB (+0.06% 🔺)
JS (gzip) 118.07 KB (+0.07% 🔺)
JS (brotli) 97.22 KB (+0.11% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 341.94 KB (+0.15% 🔺)
CSS (gzip) 42.36 KB (+0.21% 🔺)
CSS (brotli) 33.75 KB (+0.23% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (5cb14c4) to head (c82605b).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8098      +/-   ##
==========================================
- Coverage   95.60%   95.56%   -0.05%     
==========================================
  Files         398      398              
  Lines       11322    11329       +7     
  Branches     3729     3732       +3     
==========================================
+ Hits        10824    10826       +2     
- Misses        498      503       +5     
Flag Coverage Δ
unittests 95.56% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit c82605b

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 26, 2024
@EldarMuhamethanov EldarMuhamethanov merged commit ba6b9c4 into master Dec 26, 2024
27 of 28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/rtl/Slider branch December 26, 2024 14:46
@vkcom-publisher
Copy link
Contributor

v7.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:slider pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности type:feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants