Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SegmentedControl): fix rtl view #8092

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас компонент SegmentedControl в rtl работает не совсем корректно. А именно слайдер позиционируется неправильно

Изменения

  • Перенес расчет позиции и размера slider в css
  • Доработал расчет позиции slider при rtl
  • Добавил тесты функционала
  • Добавил скриншоты для rtl

Release notes

Улучшения

  • SegmentedControl: Добавлена корректная поддержка rtl

Copy link
Contributor

github-actions bot commented Dec 17, 2024

size-limit report 📦

Path Size
JS 389.68 KB (+0.07% 🔺)
JS (gzip) 118.23 KB (+0.03% 🔺)
JS (brotli) 97.43 KB (+0.17% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 342.99 KB (+0.12% 🔺)
CSS (gzip) 42.5 KB (+0.14% 🔺)
CSS (brotli) 33.85 KB (+0.09% 🔺)

Copy link

codesandbox-ci bot commented Dec 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (ba6b9c4) to head (d3fef5f).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8092   +/-   ##
=======================================
  Coverage   95.55%   95.56%           
=======================================
  Files         398      398           
  Lines       11351    11361   +10     
  Branches     3741     3744    +3     
=======================================
+ Hits        10847    10857   +10     
  Misses        504      504           
Flag Coverage Δ
unittests 95.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 24, 2024
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit d3fef5f

@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Dec 27, 2024
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅 Шикарно!

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 5, 2025
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 10, 2025
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@EldarMuhamethanov EldarMuhamethanov merged commit 02d004d into master Jan 15, 2025
30 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/rtl/segmented-control branch January 15, 2025 09:04
@vkcom-publisher
Copy link
Contributor

v7.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants