-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ActionSheet): add FocusTrap props to ActionSheet props #8057
fix(ActionSheet): add FocusTrap props to ActionSheet props #8057
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 70bcbd9 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8057 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 396 396
Lines 11235 11235
Branches 3720 3720
=======================================
Hits 10731 10731
Misses 504 504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
патч v7.0.1? |
Описание
Сейчас в
ActionSheet
нельзя прокинуть свойстваFocusTrap
по типам, хотя он используется в компоненте. Нужно доработать типActionSheetProps
Изменения
ActionSheet
, так чтобы он принимал все пропсы компонентаFocusTrap
и прокидывал их до негоRelease notes
Исправления
FocusTrap
в компонент