Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActionSheet): add FocusTrap props to ActionSheet props #8057

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Dec 10, 2024


  • Release notes

Описание

Сейчас в ActionSheet нельзя прокинуть свойства FocusTrap по типам, хотя он используется в компоненте. Нужно доработать тип ActionSheetProps

Изменения

  • Доработал тип пропсов компонента ActionSheet, так чтобы он принимал все пропсы компонента FocusTrap и прокидывал их до него

Release notes

Исправления

  • ActionSheet: Добавлена возможность прокидывать свойства FocusTrapв компонент

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 10, 2024 12:29
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 10, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 386.82 KB (0%)
JS (gzip) 117.03 KB (0%)
JS (brotli) 96.6 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 336.75 KB (0%)
CSS (gzip) 41.79 KB (0%)
CSS (brotli) 33.28 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 70bcbd9

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (334e5b2) to head (70bcbd9).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8057   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         396      396           
  Lines       11235    11235           
  Branches     3720     3720           
=======================================
  Hits        10731    10731           
  Misses        504      504           
Flag Coverage Δ
unittests 95.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit ab47895 into master Dec 10, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8044/add-action-sheet-prop-restoreFocus branch December 10, 2024 14:39
@inomdzhon
Copy link
Contributor

патч v7.0.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ActionSheet не принимает по типам пропы FocusTrap
4 participants