-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RichCell): add contentAlign and beforeAlign props #8043
feat(RichCell): add contentAlign and beforeAlign props #8043
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit 49aefc9 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8043 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 396 396
Lines 11235 11238 +3
Branches 3720 3722 +2
=======================================
+ Hits 10731 10734 +3
Misses 504 504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Супер!
Может добавим скриншотных тестов? Хотя бы для варианта из issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅 Спасибо!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Описание
Используя один из компонентов
RichCell
,SimpleCell
,MiniInfoCell
невозможно выравнить основной текст по центру, если имеется высокий контент вafter
, при этоммежду
after и контентом должен оставаться отступ какой есть уRichCell
.Изменения
RichCell
добавил свойстваcontentAlign
иbeforeAlign
для выравнивания контента по вертикалиSimpleCell
,MiniInfoCell
как мне кажется подобные свойства не нужны, так как в after не должен быть слишком высоки контентRelease notes
Улучшения
contentAlign
для выравнивания центрального контента по вертикалиbeforeAlign
для выравнивания компонентаbefore
по вертикали