Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RichCell): add contentAlign and beforeAlign props #8043

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Dec 6, 2024


  • Unit-тесты
  • e2e-тесты
  • Документация фичи
  • Release notes

Описание

Используя один из компонентов RichCell, SimpleCell, MiniInfoCell невозможно выравнить основной текст по центру, если имеется высокий контент в after, при этом между after и контентом должен оставаться отступ какой есть у RichCell.

Изменения

  • Для компонента RichCell добавил свойства contentAlign и beforeAlign для выравнивания контента по вертикали
  • Для SimpleCell, MiniInfoCell как мне кажется подобные свойства не нужны, так как в after не должен быть слишком высоки контент

Release notes

Улучшения

  • RichCell:
    • Добавлено свойство contentAlign для выравнивания центрального контента по вертикали
    • Добавлено свойство beforeAlign для выравнивания компонента before по вертикали

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 6, 2024 12:16
Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size
JS 387.01 KB (+0.05% 🔺)
JS (gzip) 117.09 KB (+0.05% 🔺)
JS (brotli) 96.46 KB (-0.15% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 336.93 KB (+0.06% 🔺)
CSS (gzip) 41.82 KB (+0.06% 🔺)
CSS (brotli) 33.31 KB (+0.1% 🔺)

Copy link

codesandbox-ci bot commented Dec 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

github-actions bot commented Dec 6, 2024

👀 Docs deployed

Commit 49aefc9

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (334e5b2) to head (49aefc9).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8043   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         396      396           
  Lines       11235    11238    +3     
  Branches     3720     3722    +2     
=======================================
+ Hits        10731    10734    +3     
  Misses        504      504           
Flag Coverage Δ
unittests 95.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Супер!

Может добавим скриншотных тестов? Хотя бы для варианта из issue?

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅 Спасибо!

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EldarMuhamethanov EldarMuhamethanov merged commit 1b32ca1 into master Dec 11, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7870/align-content-cell branch December 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants