-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Tooltip, Popover): refactor Tooltip and Popover logic #8040
refactor(Tooltip, Popover): refactor Tooltip and Popover logic #8040
Conversation
… in usePopover and useTooltip
# Conflicts: # packages/vkui/src/components/Tooltip/Tooltip.tsx
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit 2f953d1 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8040 +/- ##
==========================================
- Coverage 95.55% 95.52% -0.03%
==========================================
Files 398 401 +3
Lines 11332 11364 +32
Branches 3733 3739 +6
==========================================
+ Hits 10828 10856 +28
- Misses 504 508 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Здорово 👍
✅ v7.2.0 🎉 |
Описание
Сейчас
Popover
иTooltip
имеют очень похожие реализации, которые минимально отличаются друг от друга. Вообще если так подумать, тоTooltip
- это частный случайPopover
. Нужно придумать как объединить логикуИзменения
Release notes
Улучшения
Popover
снаружиИсправления
children
можно прокинуть обычный текст