Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ModalCard): exclude unused shouldPreserveSnapPoint #8033

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Dec 3, 2024

Описание

Параметр попадал в DOM

Release notes

Исправления

  • ModalCard: в DOM попадал параметр shouldPreserveSnapPoint, из-за чего React кидал предупреждение в консоль.

Параметр попадал в DOM
@inomdzhon inomdzhon added type:bug cmp:modal-card ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Dec 3, 2024
@inomdzhon inomdzhon added this to the v7.0.1 milestone Dec 3, 2024
@inomdzhon inomdzhon self-assigned this Dec 3, 2024
@inomdzhon inomdzhon requested a review from a team as a code owner December 3, 2024 08:50
Copy link
Contributor

github-actions bot commented Dec 3, 2024

size-limit report 📦

Path Size
JS 384.68 KB (+0.02% 🔺)
JS (gzip) 116.34 KB (+0.01% 🔺)
JS (brotli) 95.77 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 337.07 KB (0%)
CSS (gzip) 42.75 KB (0%)
CSS (brotli) 33.77 KB (0%)

Copy link

codesandbox-ci bot commented Dec 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

github-actions bot commented Dec 3, 2024

👀 Docs deployed

Commit e7ddb8e

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (90bb0cc) to head (e7ddb8e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8033   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files         393      393           
  Lines       11188    11188           
  Branches     3708     3708           
=======================================
  Hits        10682    10682           
  Misses        506      506           
Flag Coverage Δ
unittests 95.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon merged commit d654a13 into master Dec 3, 2024
28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/ModalCard-react-warning branch December 3, 2024 09:39
vkcom-publisher pushed a commit that referenced this pull request Dec 3, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча cmp:modal-card type:bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants