Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix NativeSelect name #8003

Merged
merged 1 commit into from
Dec 4, 2024
Merged

docs: fix NativeSelect name #8003

merged 1 commit into from
Dec 4, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Nov 26, 2024

Описание

styleguidist по умолчанию опирается на первый импорт чего-то, что напоминает реакт-компонент, поэтому иногда ловим артефакты с неправильным наименованием:

image

Т.к. мы не можем влиять на это поведение извне, а уносить эту функцию в отдельный файл не очень хочется - пока оставляем "костыль" 🙃

Release notes

Документация

  • NativeSelect: исправлено наименование компонента

Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size
JS 384.63 KB (0%)
JS (gzip) 116.33 KB (0%)
JS (brotli) 95.78 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 337.07 KB (0%)
CSS (gzip) 42.75 KB (0%)
CSS (brotli) 33.77 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 26, 2024

👀 Docs deployed

Commit e07929e

@BlackySoul BlackySoul self-assigned this Dec 2, 2024
@BlackySoul BlackySoul marked this pull request as ready for review December 2, 2024 11:08
@BlackySoul BlackySoul requested a review from a team as a code owner December 2, 2024 11:08
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (cb55d05) to head (e07929e).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8003      +/-   ##
==========================================
- Coverage   95.46%   95.44%   -0.03%     
==========================================
  Files         380      374       -6     
  Lines       11324    10652     -672     
  Branches     3777     3556     -221     
==========================================
- Hits        10811    10167     -644     
+ Misses        513      485      -28     
Flag Coverage Δ
unittests 95.44% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul added cmp:native-select ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug docs labels Dec 4, 2024
@BlackySoul BlackySoul merged commit f4e3b45 into master Dec 4, 2024
52 of 53 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_ns_name branch December 4, 2024 13:32
vkcom-publisher pushed a commit that referenced this pull request Dec 4, 2024
@andrey-medvedev-vk andrey-medvedev-vk added this to the v7.0.1 milestone Dec 18, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча cmp:native-select docs type:bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants