Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CarouselBase): fix error when no slides #7686

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

BlackySoul
Copy link
Contributor


Изменения

Помечаем галерею неинициализированной в случае, когда кол-во слайдов = 0

Release notes

Исправления

  • Gallery: исправлена ошибка при отсутствии слайдов в режиме looped

Copy link

codesandbox-ci bot commented Oct 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

size-limit report 📦

Path Size
JS 385.46 KB (+0.02% 🔺)
JS (gzip) 116.65 KB (+0.02% 🔺)
JS (brotli) 95.89 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.29 KB (0%)
CSS (gzip) 41.52 KB (0%)
CSS (brotli) 32.94 KB (0%)

Copy link
Contributor

github-actions bot commented Oct 1, 2024

e2e tests

Playwright Report

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.14%. Comparing base (5459b15) to head (13067e6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...mponents/BaseGallery/CarouselBase/CarouselBase.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7686      +/-   ##
==========================================
- Coverage   95.16%   95.14%   -0.02%     
==========================================
  Files         383      383              
  Lines       11335    11338       +3     
  Branches     3714     3715       +1     
==========================================
+ Hits        10787    10788       +1     
- Misses        548      550       +2     
Flag Coverage Δ
unittests 95.14% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

👀 Docs deployed

Commit 13067e6

@BlackySoul BlackySoul added v6 Автоматизация: PR продублируется в ветку v6 patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Oct 1, 2024
@BlackySoul BlackySoul merged commit 8614595 into master Oct 1, 2024
26 of 28 checks passed
@BlackySoul BlackySoul deleted the fix/7672/Gallery_fix_looped_error branch October 1, 2024 08:51
vkcom-publisher pushed a commit that referenced this pull request Oct 1, 2024
* fix(CarouselBase): fix error when no slides

* fix(Gallery): cleanup test
vkcom-publisher pushed a commit that referenced this pull request Oct 1, 2024
* fix(CarouselBase): fix error when no slides

* fix(Gallery): cleanup test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v6 Автоматизация: PR продублируется в ветку v6
Projects
None yet
3 participants