Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CustomSelect): focus index #7126

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Jul 4, 2024


Описание

Наведение в CustomSelect зависит от расположения элемента в DOM. Из-за того что первым элементом выставлялся iframe, то наведение слетало на один элемент

Изменения

Не завязываемся на расположение элемента в DOM


@SevereCloud SevereCloud marked this pull request as ready for review July 4, 2024 14:34
@SevereCloud SevereCloud requested a review from a team as a code owner July 4, 2024 14:34
Copy link
Contributor

github-actions bot commented Jul 4, 2024

size-limit report 📦

Path Size
JS 368.86 KB (-0.03% 🔽)
JS (gzip) 112.99 KB (-0.01% 🔽)
JS (brotli) 92.99 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 290.15 KB (0%)
CSS (gzip) 37.77 KB (0%)
CSS (brotli) 30.49 KB (0%)

Copy link

codesandbox-ci bot commented Jul 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jul 4, 2024

👀 Docs deployed

Commit 4363326

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.92%. Comparing base (b7489fc) to head (4363326).

Files Patch % Lines
.../vkui/src/components/CustomSelect/CustomSelect.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7126   +/-   ##
=======================================
  Coverage   83.91%   83.92%           
=======================================
  Files         357      357           
  Lines       10785    10785           
  Branches     3557     3556    -1     
=======================================
+ Hits         9050     9051    +1     
+ Misses       1735     1734    -1     
Flag Coverage Δ
unittests 83.92% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 💡

@inomdzhon inomdzhon added type:bug cmp:custom-select patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Jul 4, 2024
@inomdzhon inomdzhon added this to the v6.2.1 milestone Jul 4, 2024
@SevereCloud SevereCloud merged commit f1876bc into master Jul 5, 2024
25 of 38 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/CustomSelect/focus-index branch July 5, 2024 12:19
vkcom-publisher pushed a commit that referenced this pull request Jul 5, 2024
@SevereCloud SevereCloud removed their assignment Jul 7, 2024
@SevereCloud SevereCloud removed this from the v6.2.1 milestone Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:custom-select patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CustomSelect сломан ховер и клик по айтему
3 participants