Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UsersStack): add possibility to render custom wrapper to photo and add example to doc #7116

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat(UsersStack): add possibility to render custom wrapper to photo and add example to doc #7116

wants to merge 12 commits into from

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • Документация фичи

Описание

Необходимо добавить возможность рендеринга обертки для каждого аватара в компоненте UsersStack

Изменения

  • Добавил возможность прокидывания функции рендеринга обертки renderWrapper
  • Добавил тест проверяющий новый функционал
  • Добавил описание новой возможность в документацию, а также добавил новый пример

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner July 2, 2024 08:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 369.13 KB (+0.07% 🔺)
JS (gzip) 113.07 KB (+0.07% 🔺)
JS (brotli) 93.09 KB (+0.13% 🔺)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 290.11 KB (+0.02% 🔺)
CSS (gzip) 37.78 KB (+0.04% 🔺)
CSS (brotli) 30.5 KB (-0.07% 🔽)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 2, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.06%. Comparing base (b7489fc) to head (a886920).
Report is 4 commits behind head on master.

Files Patch % Lines
...ages/vkui/src/components/UsersStack/UsersStack.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7116      +/-   ##
==========================================
+ Coverage   83.91%   84.06%   +0.14%     
==========================================
  Files         357      357              
  Lines       10785    10791       +6     
  Branches     3557     3560       +3     
==========================================
+ Hits         9050     9071      +21     
+ Misses       1735     1720      -15
Flag Coverage Δ
unittests 84.06% <83.33%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

👀 Docs deployed

Commit a886920

inomdzhon
inomdzhon previously approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][UsersStack]: Возможность обертки аватаров в любой компонент
2 participants
@EldarMuhamethanov @inomdzhon