Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Checkbox): add tests to checkbox keyboard navigation and update doc #7101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • Документация по доступности

Изменения

  • Проверил доступность компонента Checkbox по документации. Поскольку в реализации используется input type="checkbox" все работает как надо
  • Обновил доку по компоненту Checkbox. Добавил раздел "Цифровая доступность"
  • Добавил тест для проверки навигации табами по checkbox-ам

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner June 29, 2024 14:49
Copy link
Contributor

github-actions bot commented Jun 29, 2024

size-limit report 📦

Path Size
JS 368.84 KB (0%)
JS (gzip) 112.95 KB (0%)
JS (brotli) 92.98 KB (0%)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 290.04 KB (0%)
CSS (gzip) 37.72 KB (0%)
CSS (brotli) 30.47 KB (0%)

Copy link

codesandbox-ci bot commented Jun 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jun 29, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jun 29, 2024

👀 Docs deployed

Commit 1c9206e

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (9ba0c02) to head (1c9206e).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7101      +/-   ##
==========================================
+ Coverage   83.78%   83.91%   +0.12%     
==========================================
  Files         357      357              
  Lines       10676    10785     +109     
  Branches     3551     3557       +6     
==========================================
+ Hits         8945     9050     +105     
- Misses       1731     1735       +4     
Flag Coverage Δ
unittests 83.91% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Daniil Suvorov <[email protected]>
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement][a11y] Добавить доступность для Checkbox
3 participants