fix(AccordionContent): refactor for useCSSKeyframesAnimationController() #7083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Чтобы не зашивать `max-height`, устанавливаем его тогда, когда нужно (с переходом с `transition` на `animation` заменил на использование `height`). Сделал для удобства, через CSS переменную, которую добавляем/удалям в `useLayoutEffect()` относительно `animationState`. По умолчанию, переменная со значением `initial`. Для `@media (--reduce-motion)` заменяем анимацию на `opacity`.
github-actions
bot
added
the
patch
inomdzhon
removed
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit dbaf573 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
+ Coverage 83.57% 83.60% +0.02%
==========================================
Files 352 352
Lines 10551 10551
Branches 3489 3492 +3
==========================================
+ Hits 8818 8821 +3
+ Misses 1733 1730 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
reviewed
Jun 26, 2024
SevereCloud
previously approved these changes
Jun 26, 2024
SevereCloud
approved these changes
Jun 26, 2024
inomdzhon
deleted the
imirdzhamolov/fix/AccrodionContent-expand-animation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Чтобы не зашивать
max-height, устанавливаем его тогда, когда нужно (с переходом сtransitionнаanimationзаменил на использованиеheight). Сделал для удобства, через CSS переменную, которую добавляем/удалям вuseLayoutEffect()относительноanimationState. По умолчанию, переменная со значениемinitial.Для
@media (--reduce-motion)заменяем анимацию наopacity.