fix(useExternRef): rm useMemo #7077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- see #6920 --- ## Описание Для компилятора требуется знать точные зависимости в useMemo ## Изменение Избавился от useMemo, написал отдельный класс реализующий MutableRefObject
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
SevereCloud
removed
patch
e2e tests |
👀 Docs deployed
Commit eef90a5 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7077 +/- ##
==========================================
+ Coverage 83.57% 83.59% +0.02%
==========================================
Files 352 352
Lines 10551 10564 +13
Branches 3489 3493 +4
==========================================
+ Hits 8818 8831 +13
Misses 1733 1733
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
reviewed
Jun 26, 2024
vkcom-publisher
added
pr-needs-work
inomdzhon
approved these changes
Jul 9, 2024
SevereCloud
added a commit
that referenced
this pull request
Jul 9, 2024
> Unexpected ref object provided for %s. Use either a ref-setter function or React.createRef(). React проверяет наличие свойства current у объектов через hasOwnProperty и генерирует ошибки Исправляем реализацией hasOwnProperty - cause #7077
SevereCloud
added a commit
that referenced
this pull request
Jul 9, 2024
> Unexpected ref object provided for %s. Use either a ref-setter function or React.createRef(). React проверяет наличие свойства current у объектов через hasOwnProperty и генерирует ошибки Исправляем реализацией hasOwnProperty - cause #7077
SevereCloud
added a commit
that referenced
this pull request
Jul 10, 2024
> Unexpected ref object provided for %s. Use either a ref-setter function or React.createRef(). React проверяет наличие свойства current у объектов через hasOwnProperty и генерирует ошибки Исправляем реализацией hasOwnProperty - cause #7077
| ✅ v6.3.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Для компилятора требуется знать точные зависимости в useMemo
Изменение
Избавился от useMemo, написал отдельный класс реализующий MutableRefObject