Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(File): add empty title #6696

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(File): add empty title #6696

merged 1 commit into from
Mar 14, 2024

Conversation

SevereCloud
Copy link
Contributor

Описание

Браузер для input type="file" пишет свой текст("Выберите файл"). Из-за этого скринридер прочитает сначала что написано в label, а потом что написано в title

Изменения

Добавляем пустой title

@SevereCloud SevereCloud requested a review from a team as a code owner March 14, 2024 11:20
@SevereCloud SevereCloud added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 14, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 356.31 KB (+0.01% 🔺)
JS (gzip) 108.71 KB (+0.01% 🔺)
JS (brotli) 89.76 KB (-0.12% 🔽)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 260.93 KB (0%)
CSS (gzip) 34.19 KB (0%)
CSS (brotli) 27.76 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 4aac4d3

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.35%. Comparing base (8b9056b) to head (4aac4d3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6696   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files         335      335           
  Lines       10329    10329           
  Branches     3460     3460           
=======================================
  Hits         8506     8506           
  Misses       1823     1823           
Flag Coverage Δ
unittests 82.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud merged commit 99afe21 into master Mar 14, 2024
27 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue2562 branch March 14, 2024 13:20
vkcom-publisher pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement][a11y] Доступность File
3 participants