Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pagination): add caption property #6630

Merged

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Feb 26, 2024


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Добавляем возможность переключать отображение навигирования.

Создал для этого 3 новых пропса:

  • navigationButtonsStyle
  • prevButtonCaption
  • nextButtonCaption

Изменения

  • поправил текст для getPageLabel – "с" была латиницей (⚡ 36f2530)

@inomdzhon inomdzhon changed the title feat(Pagination): add caption properties feat(Pagination): add caption property Feb 26, 2024
Copy link
Contributor

github-actions bot commented Feb 26, 2024

size-limit report 📦

Path Size
JS 354.41 KB (+0.15% 🔺)
JS (gzip) 108.27 KB (+0.16% 🔺)
JS (brotli) 89.54 KB (+0.18% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 257.99 KB (0%)
CSS (gzip) 33.81 KB (0%)
CSS (brotli) 27.44 KB (0%)

Copy link

codesandbox-ci bot commented Feb 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Feb 26, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Feb 26, 2024

👀 Docs deployed

Commit 8b4c373

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (9f2d05c) to head (8b4c373).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6630      +/-   ##
==========================================
+ Coverage   82.20%   82.58%   +0.37%     
==========================================
  Files         331      332       +1     
  Lines       10219    10494     +275     
  Branches     3422     3579     +157     
==========================================
+ Hits         8401     8666     +265     
- Misses       1818     1828      +10     
Flag Coverage Δ
unittests 82.58% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon
Copy link
Contributor Author

@Fliqle нужон дизайн-ревью

Примеры в песочнице:

@inomdzhon inomdzhon force-pushed the imirdzhamolov/issue6528/feat/Pagination-customize-nav-button branch from 72281d5 to 8b4c373 Compare February 26, 2024 12:52
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 5, 2024
@vkcom-publisher
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@Fliqle Fliqle reopened this Mar 13, 2024
@Fliqle Fliqle marked this pull request as ready for review March 13, 2024 13:40
@Fliqle Fliqle requested a review from a team as a code owner March 13, 2024 13:40
@inomdzhon inomdzhon removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Mar 13, 2024
@inomdzhon inomdzhon merged commit ebe53a3 into master Mar 13, 2024
52 of 70 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/issue6528/feat/Pagination-customize-nav-button branch March 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants