Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch(5.10-stable): pr6489 #6585

Merged
merged 1 commit into from
Feb 16, 2024
Merged

patch(5.10-stable): pr6489 #6585

merged 1 commit into from
Feb 16, 2024

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Feb 16, 2024 •
edited by inomdzhon
Loading

@mendrew
Applying changes from v6 to AdaptiveProvider (#6536)
c95dfab 
Это черри пик merge коммита bf26ee0 из #6489 
Попытка перенести исправления в подсчёте `sizeY` у `AdoptivityProvider` из v6 в v5.

#6476) был именно для v5.

- в целом мы полностью переносим логику затрагивающую работу `AdoptivityProvider` без `bridge`.
В то же время логику c `bridge` мы не трогаем. В том числе оставляем *неявное* использование `_hasPointer` из `vkjs` и игнорирование `hasPointer` свойства `AdoptivityProvider`. Сделано специально, чтобы никак не затронуть пользователей bridge, ведь на них баг не распространяется.
https://github.com/VKCOM/VKUI/blob/f361335092b365360b3b8ee65c145fb6b621a414/packages/vkui/src/components/AdaptivityProvider/AdaptivityProvider.tsx#L105-L112
https://github.com/VKCOM/VKUI/blob/f361335092b365360b3b8ee65c145fb6b621a414/packages/vkui/src/components/AdaptivityProvider/AdaptivityProvider.tsx#L2

```js
export const hasMouse = /*#__PURE__*/ (() => detect.hasMouse)();
```
[hasMouse source](https://github.com/VKCOM/vkjs/blob/3ab9216c6c9f7f48998176e9403eaba7450b9a31/src/InputUtils.ts#L48)

Также я заметил, что есть специльный тест, котороый реагирует именно на `_hasPointer` проверку, так что оставил, в v6 мы всё равно это убираем.
https://github.com/VKCOM/VKUI/blob/f361335092b365360b3b8ee65c145fb6b621a414/packages/vkui/src/components/AdaptivityProvider/AdaptivityProvider.test.tsx#L300-L308
@mendrew mendrew requested a review from a team as a code owner February 16, 2024 11:15
@mendrew mendrew added this to the v5.10.1 milestone Feb 16, 2024
@mendrew mendrew self-assigned this Feb 16, 2024
@mendrew mendrew merged commit f662902 into 5.10-stable Feb 16, 2024
16 of 19 checks passed
@mendrew mendrew deleted the mendrew/patch/v5.10-stable/pr6489 branch February 16, 2024 11:17
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 371.54 KB (0%)
JS (gzip) 111.96 KB (0%)
JS (brotli) 90.89 KB (0%)
JS import Div (tree shaking) 2.74 KB (0%)
CSS 286.13 KB (0%)
CSS (gzip) 36.68 KB (0%)
CSS (brotli) 29.16 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit c95dfab

@inomdzhon inomdzhon removed the v5.10.1 label Feb 28, 2024
@inomdzhon inomdzhon removed this from the v5.10.1 milestone Feb 28, 2024
@inomdzhon inomdzhon linked an issue Feb 28, 2024 that may be closed by this pull request
[Bug][AdaptivityProvider]: не вычисляется sizeY при передаче только viewWidth #6476
Closed
@inomdzhon inomdzhon changed the title patch(5.10-stable): pr6489G patch(5.10-stable): pr6489 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@SevereCloud SevereCloud SevereCloud approved these changes

Assignees

@mendrew mendrew

Labels
None yet
Projects
VKUI
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][AdaptivityProvider]: не вычисляется sizeY при передаче только viewWidth
3 participants
@mendrew @inomdzhon @SevereCloud