Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormField): rm outline #6557

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix(FormField): rm outline #6557

merged 1 commit into from
Feb 13, 2024

Conversation

SevereCloud
Copy link
Contributor


  • [ ] Unit-тесты
  • e2e-тесты
  • [ ] Дизайн-ревью
  • [ ] Документация фичи

Описание

В сафари outline сабпиксельного размера плохо рендерится на некоторых устройствах

Изменения

Вместо outline меняется цвет у border

В сафари outline сабпиксельного размера плохо рендерится на некоторых устройствах

- https://bugs.webkit.org/show_bug.cgi?id=60749
- fixes #6556
@SevereCloud SevereCloud requested a review from a team as a code owner February 12, 2024 10:23
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 12, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 349.33 KB (0%)
JS (gzip) 106.79 KB (0%)
JS (brotli) 88.34 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 257.77 KB (-0.05% 🔽)
CSS (gzip) 33.8 KB (-0.02% 🔽)
CSS (brotli) 27.45 KB (-0.07% 🔽)

@BlackySoul
Copy link
Contributor

А это разве не должно повлиять на возвращение бага из #5876 ?

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8e56c62:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 8e56c62

@SevereCloud
Copy link
Contributor Author

SevereCloud commented Feb 12, 2024

А это разве не должно повлиять на возвращение бага из #5876 ?

Здесь нет возрата к прошлой логике работе фокуса. Просто перекрашивается бордер FormField в другой цвет

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@SevereCloud SevereCloud merged commit 7bbbfd0 into master Feb 13, 2024
25 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue6556 branch February 13, 2024 13:56
vkcom-publisher pushed a commit that referenced this pull request Feb 13, 2024
В сафари outline сабпиксельного размера плохо рендерится на некоторых устройствах

- https://bugs.webkit.org/show_bug.cgi?id=60749
- fixes #6556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Input. Outline на iOS не работает
4 participants