Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add popper changes for v6 #6482

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Jan 29, 2024

  • Unit-тесты

Описание

Принесли фидбэк по гайду миграции и codemod:

  • У компонента Tooltip был проп arrow, в 6 версии у OnboardingTooltip его убрали. В гайде по миграции об этом не сказано, codemods тоже никак об этом не сообщает
  • У Popover был проп onPlacementChange, в 6 версии его убрали. В гайде по миграции об этом не сказано, codemods тоже никак об этом не сообщает
  • codemods не переименовывает TooltipContainer. В гайде не упоминается о переименовании TooltipContainer в OnboardingTooltipContainer

Изменения

  • Добавлен проп disableArrow у OnboardingTooltip, взамен arrow
  • у всех всплывающих элементов добавлен onPlacementChange, какой был в v5
  • Добавлен codemod для переименовывания TooltipContainer в OnboardingTooltipContainer и замена пропа arrow на disableArrow в Tooltip

@BlackySoul BlackySoul requested a review from a team as a code owner January 29, 2024 07:56
@BlackySoul BlackySoul self-assigned this Jan 29, 2024
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jan 29, 2024
@BlackySoul BlackySoul added this to the v6.0.1 milestone Jan 29, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 349.14 KB (+0.07% 🔺)
JS (gzip) 106.73 KB (+0.05% 🔺)
JS (brotli) 88.23 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 257.96 KB (0%)
CSS (gzip) 33.81 KB (0%)
CSS (brotli) 27.51 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 41af9f6:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 41af9f6

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9918a9d) 82.01% compared to head (41af9f6) 82.02%.
Report is 11 commits behind head on master.

Files Patch % Lines
...components/OnboardingTooltip/OnboardingTooltip.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6482   +/-   ##
=======================================
  Coverage   82.01%   82.02%           
=======================================
  Files         327      328    +1     
  Lines       10154    10165   +11     
  Branches     3420     3423    +3     
=======================================
+ Hits         8328     8338   +10     
- Misses       1826     1827    +1     
Flag Coverage Δ
unittests 82.02% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 спасибо🙏

с хуком красивое получилось

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@BlackySoul BlackySoul merged commit 7f31060 into master Jan 29, 2024
27 checks passed
@BlackySoul BlackySoul deleted the blackysoul/codemod_v6_up_do_date branch January 29, 2024 09:57
vkcom-publisher pushed a commit that referenced this pull request Jan 29, 2024
@vkcom-publisher
Copy link
Contributor

v6.0.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча subpackage:@vkontakte/vkui-codemods type:bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants