Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Radio): extend by Tappablep props #6455

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Jan 25, 2024

Описание

Иногда нужна возможность управлять hover/active состоянием компонента (например, при размещении его в ячейке таблицы)

Изменения

Дает возможность пробросить свойства 'hoverMode' | 'activeMode' | 'hasHover' | 'hasActive' | 'focusVisibleMode'

@BlackySoul BlackySoul requested a review from a team as a code owner January 25, 2024 14:16
@BlackySoul BlackySoul self-assigned this Jan 25, 2024
@BlackySoul BlackySoul added this to the v6.1.0 milestone Jan 25, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 348.74 KB (+0.06% 🔺)
JS (gzip) 106.62 KB (+0.01% 🔺)
JS (brotli) 88.2 KB (+0.11% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 257.19 KB (0%)
CSS (gzip) 33.71 KB (0%)
CSS (brotli) 27.38 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8012427:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 8012427

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ccc5fa) 82.00% compared to head (8012427) 82.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6455   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files         327      327           
  Lines       10149    10149           
  Branches     3418     3418           
=======================================
  Hits         8323     8323           
  Misses       1826     1826           
Flag Coverage Δ
unittests 82.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul merged commit a80760b into master Jan 26, 2024
27 checks passed
@BlackySoul BlackySoul deleted the blackysoul/radio_tappable_props branch January 26, 2024 04:24
@vkcom-publisher
Copy link
Contributor

v6.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants