Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Boolean props to false values #6286

Merged
merged 6 commits into from
Dec 25, 2023
Merged

Conversation

BlackySoul
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты

- [ ] Дизайн-ревью

  • Документация фичи
  • Гайд миграции

Описание

Как и было сказано в дискуссии, улучшаем api, чтобы не было необходимости писать booleanValue={false}

Изменения

Некоторые пропы, которые по умолчанию задавалась как boolean с дефолтовым true значением, переименованы в идентичные, инвертированные по смыслу

Copy link
Contributor

github-actions bot commented Dec 15, 2023

size-limit report 📦

Path Size
JS 347.47 KB (+0.02% 🔺)
JS (gzip) 106.18 KB (+0.02% 🔺)
JS (brotli) 87.71 KB (+0.02% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 258.02 KB (0%)
CSS (gzip) 33.66 KB (0%)
CSS (brotli) 27.34 KB (0%)

Copy link

codesandbox-ci bot commented Dec 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6971a43:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

github-actions bot commented Dec 15, 2023

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Dec 15, 2023

👀 Docs deployed

Commit 6971a43

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (8736a0c) 81.53% compared to head (6971a43) 81.21%.
Report is 8 commits behind head on master.

Files Patch % Lines
...mponents/BaseGallery/CarouselBase/CarouselBase.tsx 0.00% 18 Missing ⚠️
...es/vkui/src/components/BaseGallery/BaseGallery.tsx 26.66% 11 Missing ⚠️
...es/vkui/src/components/Placeholder/Placeholder.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6286      +/-   ##
==========================================
- Coverage   81.53%   81.21%   -0.32%     
==========================================
  Files         324      324              
  Lines       10084    10088       +4     
  Branches     3379     3383       +4     
==========================================
- Hits         8222     8193      -29     
- Misses       1862     1895      +33     
Flag Coverage Δ
unittests 81.21% <44.44%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Роскошно! 🎇

ps: скриншоты упали

packages/vkui/src/components/Textarea/Textarea.tsx Outdated Show resolved Hide resolved
@BlackySoul
Copy link
Contributor Author

Playwright Report

А там просто коммент не апдейтнулся, скриншоты все есть х)

@inomdzhon
Copy link
Contributor

Playwright Report

А там просто коммент не апдейтнулся, скриншоты все есть х)

ну ладно, ладно..... тогда.... конфликтик в styleguide/pages/migration_v6.md 😈

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Классно 🚀 , только одно замечание в migration guide.

styleguide/pages/migration_v6.md Outdated Show resolved Hide resolved
Co-authored-by: Andrey Medvedev <[email protected]>
mendrew
mendrew previously approved these changes Dec 25, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@BlackySoul BlackySoul merged commit f6fa745 into master Dec 25, 2023
23 of 25 checks passed
@BlackySoul BlackySoul deleted the feat/6149/move_to_falsy_values branch December 25, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Сделать булевые пропы по умолчанию falsy
5 participants