Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: Add Flex component #6226

Merged
merged 10 commits into from
Jun 27, 2024
Merged

tech: Add Flex component #6226

merged 10 commits into from
Jun 27, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Dec 7, 2023 •
edited
Loading

- [ ] Unit-тесты

- [ ] e2e-тесты

  • Дизайн-ревью

  • Документация фичи

- [ ] Гайд миграции

Описание

Добавляем черновой вариант Flex компонента для позиционирования

Изменения

Позаменяла хардкод в документации на новый компонент

@BlackySoul BlackySoul requested a review from a team as a code owner December 7, 2023 04:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

size-limit report 📦

Path Size
JS 366.56 KB (+0.59% 🔺)
JS (gzip) 112.17 KB (+0.55% 🔺)
JS (brotli) 92.29 KB (+0.47% 🔺)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 288.51 KB (+1.15% 🔺)
CSS (gzip) 37.46 KB (+1.3% 🔺)
CSS (brotli) 30.31 KB (+1.3% 🔺)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 7, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited
Loading

👀 Docs deployed

Commit 9efbc12

@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.61%. Comparing base (a8fd64f) to head (30af5fd).
Report is 3 commits behind head on master.

❗ Current head 30af5fd differs from pull request most recent head 9efbc12

Please upload reports for the commit 9efbc12 to get more accurate results.

Files Patch % Lines
packages/vkui/src/components/Flex/Flex.tsx 92.59% 2 Missing ⚠️
packages/vkui/src/lib/layouts/index.ts 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6226      +/-   ##
==========================================
+ Coverage   83.57%   83.61%   +0.03%     
==========================================
  Files         352      356       +4     
  Lines       10551    10599      +48     
  Branches     3489     3507      +18     
==========================================
+ Hits         8818     8862      +44     
- Misses       1733     1737       +4
Flag Coverage Δ
unittests 83.61% <91.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul self-assigned this Dec 11, 2023
@BlackySoul BlackySoul added this to the v6 milestone Dec 11, 2023
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 19, 2023
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Dec 27, 2023
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Jan 5, 2024
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 14, 2024
@inomdzhon inomdzhon modified the milestones: v6, v6.1.0 Jan 16, 2024
@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 17, 2024
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Jan 24, 2024
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Feb 2, 2024
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Feb 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-actions github-actions bot closed this Feb 18, 2024
@inomdzhon inomdzhon modified the milestones: v6.1.0, v6.2.0 May 22, 2024
@inomdzhon inomdzhon added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels May 22, 2024
@inomdzhon inomdzhon reopened this May 22, 2024
@inomdzhon inomdzhon marked this pull request as draft May 22, 2024 14:10
@BlackySoul BlackySoul force-pushed the blackysoul/add_flex_component branch from e8c79f4 to 6eb73ba Compare June 25, 2024 16:46
@BlackySoul BlackySoul marked this pull request as ready for review June 25, 2024 17:04
mendrew
mendrew previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Офигенно! 👏 🔥 🏅
Выглядит очень удобно!

  1. Хочется убрать 3xs токен, так как он deprecated в vkui-tokens
    https://github.com/VKCOM/vkui-tokens/blob/2222b5b2208df9ea2d1f8d449e683f34696c6cd4/src/interfaces/general/geometry/index.ts#L439-L445

  2. Почаще бы использовать именно токены (m, s, l) в доке там, где отступы совпадают с токенами.

packages/vkui/src/components/Flex/Flex.e2e-playground.tsx Outdated Show resolved Hide resolved
packages/vkui/src/components/Flex/Readme.md Outdated Show resolved Hide resolved
mendrew
mendrew approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@BlackySoul BlackySoul merged commit 163238b into master Jun 27, 2024
24 checks passed
@BlackySoul BlackySoul deleted the blackysoul/add_flex_component branch June 27, 2024 09:55
@vkcom-publisher
Copy link
Contributor

✅ v6.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mendrew mendrew mendrew approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

@SevereCloud SevereCloud SevereCloud approved these changes

Assignees

@BlackySoul BlackySoul

Labels
no-stale Добавляет PR в исключения для автоматического закрытия
Projects
VKUI
Archived in project
Milestone
v6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BlackySoul @vkcom-publisher @mendrew @inomdzhon @SevereCloud