[BREAKING CHANGE] feat(Popover): mv to stable #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2f071e9:
|
e2e tests |
👀 Docs deployed
Commit 2f071e9 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6129 +/- ##
==========================================
+ Coverage 80.16% 80.78% +0.62%
==========================================
Files 312 315 +3
Lines 9814 9807 -7
Branches 3297 3305 +8
==========================================
+ Hits 7867 7923 +56
+ Misses 1947 1884 -63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
force-pushed
the
imirdzhamolov/issue2523/feat/Popover-to-stable
branch
from
769d13d
to
1563164
Compare
inomdzhon
force-pushed
the
imirdzhamolov/issue2523/feat/Popover-to-stable
branch
from
1563164
to
c6505ce
Compare
inomdzhon
force-pushed
the
imirdzhamolov/issue2523/feat/Popover-to-stable
branch
from
c6505ce
to
dbd1dae
Compare
inomdzhon
force-pushed
the
imirdzhamolov/issue2523/feat/Popover-to-stable
branch
from
dbd1dae
to
66ab260
Compare
inomdzhon
force-pushed
the
imirdzhamolov/issue2523/feat/Popover-to-stable
branch
from
66ab260
to
5b7fb62
Compare
inomdzhon
changed the title
inomdzhon
changed the title
inomdzhon
force-pushed
the
imirdzhamolov/issue2523/feat/Popover-to-stable
branch
from
5b7fb62
to
e026d9e
Compare
SevereCloud
previously approved these changes
Dec 1, 2023
|
Пример на мобилке поехал 😃 |
пля |
BlackySoul
reviewed
Dec 1, 2023
|
А в гайде по миграции не нужно расписать, что компонент больше не нестабильный?) |
BlackySoul
reviewed
Dec 1, 2023
🎉 Теперь экспортируется как стабильный компонент.
```diff
<Popover
- action="hover"
+ trigger="hover"
- offsetDistance={0}
+ offsetByMainAxis={0}
- offsetSkidding={0}
+ offsetByCrossAxis={0}
- shownDelay={0}
- hideDelay={10}
+ hoverDelay={[0, 10]}
>
<div>Target</div>
</Popover>
```
- `trigger` – помимо `"click"` и `"hover"`, теперь принимает `"focus"` или комбинацию этих событий.
Также можно передать `"manual"`, что сделает компонент полностью контролируемым, в `onShownChange`
будет вызываться при нажатии за пределы целевого и всплывающего элементов, по кнопке ESC или при
вызове `onClose` из свойства `content`.
- `content` теперь принимает [render prop](https://react.dev/reference/react/cloneElement#passing-data-with-a-render-prop).
В аргументе функции можно получить метод `onClose`, с помощью которого можно программно закрывать
всплывающий элемента.
- `onShownChange` – вторым аргументом теперь приходит `reason`, который даёт понять по какой причине
показался/скрылся всплывающий элемент.
- `hoverDelay` – принимает либо общее число задержки для `trigger="hover"`, либо массив чисел типа
`[<показ>, <скрытие>]`.
- `autoFocus` – включать ли авто-фокусирование на всплывающий элемент (работает при навигации с клавиатуры).
- `noStyling` – убирает стилизацию по умолчанию.
- `usePortal` – рендерить ли всплывающий элемент в портале. Вместо `boolean`, можно передать
контейнер, куда должен отрендериться всплывающий элемент.
inomdzhon
force-pushed
the
imirdzhamolov/issue2523/feat/Popover-to-stable
branch
from
e026d9e
to
fbab034
Compare
🙈 Будет в ветке https://github.com/VKCOM/VKUI/tree/blackysoul/update_migration_guide ) |
Убрал использование |
SevereCloud
previously approved these changes
Dec 1, 2023
mendrew
approved these changes
Dec 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
action->triggershowDelay/hideDelay->hoverDelaycontent– теперь может быть функциейoffsetDistance->offsetByMainAxisoffsetSkidding->offsetByCrossAxisautoFocusnoStylingusePortallib/animation.Видео Popover
2023-12-01.11.02.59.mov
Изменения
injectAriaExpandedPropByRole, который добавляет в пропыaria-expandedс тоглом значения