feat(CustomSelect,ChipsSelect): add noMaxHeight prop #6045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1adacae:
|
e2e tests |
👀 Docs deployed
Commit 1adacae |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6045 +/- ##
==========================================
+ Coverage 79.21% 79.23% +0.02%
==========================================
Files 305 305
Lines 9588 9600 +12
Branches 3244 3249 +5
==========================================
+ Hits 7595 7607 +12
Misses 1993 1993
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
SevereCloud
previously approved these changes
Oct 24, 2023
inomdzhon
previously approved these changes
Oct 24, 2023
BlackySoul
dismissed stale reviews from inomdzhon and SevereCloud
via
1adacae
BlackySoul
force-pushed
the
feat/5915/CustomSelectSelect_add_maxWidth_prop
branch
from
5ddbb02 to
1adacae
Compare
inomdzhon
approved these changes
Oct 30, 2023
SevereCloud
approved these changes
Oct 30, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Oct 30, 2023
* feat(CustomSelect,ChipsSelect): add noMaxHeight prop * chore: add screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] Unit-тесты- [ ] Дизайн-ревью- [ ] Документация фичиОписание
Иногда требуется показать контент без скролла
Изменения
Добавлен проп
noMaxHeight, позволяющий отключить задание максимальной высоты