Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IconButton is Primitives #6035

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: IconButton is Primitives #6035

merged 1 commit into from
Oct 23, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Oct 23, 2023


  • [ ] Unit-тесты
  • [ ] e2e-тесты
  • [ ] Дизайн-ревью
  • [ ] Документация фичи

На текущий момент не понятно как это отлавливать, необходимо уменьшить зацепление компонентов и прописать на уровне линтера что может импортироваться в другие компоненты

Описание

Стили IconButton перебивают другие стили в обычной сборке

Изменения

Поднял IconButton выше других элементов

@SevereCloud SevereCloud requested a review from a team as a code owner October 23, 2023 14:24
@github-actions github-actions bot added ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Oct 23, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 331.45 KB (0%)
JS (gzip) 101.27 KB (-0.02% 🔽)
JS (brotli) 83.53 KB (-0.15% 🔽)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 255.99 KB (0%)
CSS (gzip) 33.59 KB (-0.04% 🔽)
CSS (brotli) 27.26 KB (-0.03% 🔽)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a1fc188:

Sandbox Source
VKUI TypeScript Configuration
Alert dissmis Issue #6034

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit a1fc188

@SevereCloud SevereCloud merged commit 8202c8a into master Oct 23, 2023
@SevereCloud SevereCloud deleted the SevereCloud/issue6034 branch October 23, 2023 15:19
vkcom-publisher pushed a commit that referenced this pull request Oct 23, 2023
vkcom-publisher pushed a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Alert крестик не на своем месте из-за специфичности
3 participants