fix(CustomSelect): CustomSelectRenderOption #5950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevereCloud
added
ci:cherry-pick:patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bf35788:
|
e2e tests |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5950 +/- ##
=======================================
Coverage 79.19% 79.19%
=======================================
Files 304 304
Lines 9516 9516
Branches 3219 3219
=======================================
Hits 7536 7536
Misses 1980 1980
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
BlackySoul
approved these changes
Oct 11, 2023
eugpoloz
approved these changes
Oct 11, 2023
SevereCloud
deleted the
SevereCloud/fix/CustomSelect/CustomSelectRenderOption
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Oct 11, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Oct 11, 2023
| ✅ v5.9.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Unit-тесты(Фикс типизации)[ ] e2e-тесты(Фикс типизации)[ ] Дизайн-ревью(Фикс типизации)[ ] Документация фичи(Фикс типизации)Изменения
Исправляем типизацию для функции
renderOption, так как свойствоCustomSelectOption['option']является deprecated