feat(Snackbar): Basic #5932
Merged
feat(Snackbar): Basic #5932
+350
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3543037:
|
e2e tests |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5932 +/- ##
==========================================
+ Coverage 79.15% 79.26% +0.10%
==========================================
Files 306 306
Lines 9553 9612 +59
Branches 3230 3254 +24
==========================================
+ Hits 7562 7619 +57
- Misses 1991 1993 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit 3543037 |
- closed #5929
SevereCloud
force-pushed
the
SevereCloud/issue5929
branch
from
819fe86 to
3a68063
Compare
Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
inomdzhon
previously approved these changes
Oct 19, 2023
github-actions
bot
added
the
pr-needs-work
|
Здесь кнопка справа не должна быть белого цвета? |
Поправил скриншотный тест |
BlackySoul
approved these changes
Oct 30, 2023
inomdzhon
approved these changes
Oct 30, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Oct 30, 2023
* feat(Snackbar): Basic - closed #5929 * docs: add new description Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team> * test(e2e): update mode=dark --------- Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
inomdzhon
removed
the
pr-needs-work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Дизайн-ревьювнешний вид не изменялсяОписание
Добавляем компонент Snackbar.Basic
Изменения
Перенес базовый снэкбар в отдельный компонент. css не трогал, только перенес