Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(BaseImage): Add prop to turn on transparent background #5924

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Oct 5, 2023


  • e2e-тесты

Описание

Добавляем проп withTransparentBackground чтобы можно было включить прозрачный фон вместо фона по умолчанию.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

size-limit report 📦

Path Size
JS 324.8 KB (+0.03% 🔺)
JS (gzip) 99.04 KB (+0.03% 🔺)
JS (brotli) 81.83 KB (-0.02% 🔽)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 278.47 KB (+0.03% 🔺)
CSS (gzip) 36.11 KB (+0.03% 🔺)
CSS (brotli) 28.67 KB (+0.15% 🔺)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb22e39:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

👀 Docs deployed

Commit eb22e39

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fcfe672) 79.18% compared to head (eb22e39) 79.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5924   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files         304      304           
  Lines        9513     9514    +1     
  Branches     3216     3217    +1     
=======================================
+ Hits         7533     7534    +1     
  Misses       1980     1980           
Flag Coverage Δ
unittests 79.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/vkui/src/components/ImageBase/ImageBase.tsx 92.59% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew marked this pull request as ready for review October 6, 2023 07:40
@mendrew mendrew requested a review from a team as a code owner October 6, 2023 07:40
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Oct 6, 2023
@mendrew mendrew merged commit 9ec750c into master Oct 6, 2023
@mendrew mendrew deleted the mendrew/feature/Image/5865/transparent-background branch October 6, 2023 11:13
vkcom-publisher pushed a commit that referenced this pull request Oct 6, 2023
Добавляем проп withTransparentBackground чтобы можно было включить прозрачный фон вместо фона по умолчанию.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Image]: transparent режим для фона
3 participants