Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HorizontalCell): Don't render HorizontalCell__content if it's empty #5884

Merged

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Sep 28, 2023

Описание

Убираем блок с .HorizontaCell__content если в нём нечего рендерить, чтобы не занимал места.

Sorry, something went wrong.

@mendrew mendrew added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

size-limit report 📦

Path Size
JS 317.11 KB (+0.01% 🔺)
JS (gzip) 96.75 KB (+0.01% 🔺)
JS (brotli) 80.11 KB (+0.04% 🔺)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 276.99 KB (0%)
CSS (gzip) 36.1 KB (0%)
CSS (brotli) 28.62 KB (0%)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4abb70f:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

👀 Docs deployed

Commit 4abb70f

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2815c3b) 81.19% compared to head (4abb70f) 81.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5884   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files         299      299           
  Lines        9189     9191    +2     
  Branches     3120     3122    +2     
=======================================
+ Hits         7461     7463    +2     
  Misses       1728     1728           
Flag Coverage Δ
unittests 81.19% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/src/components/HorizontalCell/HorizontalCell.tsx 84.61% <71.42%> (+1.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew marked this pull request as ready for review September 28, 2023 09:34
@mendrew mendrew requested a review from a team as a code owner September 28, 2023 09:34
@mendrew mendrew merged commit 0991c22 into master Sep 28, 2023
@mendrew mendrew deleted the mendrew/feat/HorizontalCell/don-t-render-content-if-empty branch September 28, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: .vkuiHorizontalCell__content присутствует в компоненте всегда
3 participants