fix(SimpleCell): Get rid of selector complexity to define icon color #5873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we might override color specified in upper components like CellButton, especially in icons passed without .vkuiIcon class
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 517d903:
|
e2e tests |
👀 Docs deployed
Commit 517d903 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5873 +/- ##
=======================================
Coverage 81.18% 81.19%
=======================================
Files 299 299
Lines 9190 9189 -1
Branches 3121 3120 -1
=======================================
Hits 7461 7461
+ Misses 1729 1728 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
SevereCloud
previously approved these changes
Sep 27, 2023
From one :global() to another, though
SevereCloud
reviewed
Sep 27, 2023
Define the variable in the CellButton Fix CellButton case with ImageBase where the color is no longer changes with Image base is using inside CellButton
Simplify ImageBase icon color setup
Seems like nothing is messing with it
SevereCloud
approved these changes
Sep 27, 2023
@SevereCloud Как-будто будет удобно P.S. я вижу что ты и сам это заметил, но я оставлю для истории. |
mendrew
changed the title
BlackySoul
approved these changes
Sep 28, 2023
mendrew
deleted the
mendrew/fix/CellButton/SimpleCell/before-icon-color
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 28, 2023
…5873) * Описание - related to #5794 [SimpleCell.module.css](https://github.com/VKCOM/VKUI/pull/5794/files#diff-cde505330a0123c800ac2efb02f954a76b39dfafaa0c5250dfb355bafddb7596) Выставление `color` явно в `.SimpleCell__before` перебивает цвет заданный в вышестоящем компоненте, таком как `CellButton`. В итоге влияет иконку без класса `.vkuiIcon`. https://github.com/VKCOM/VKUI/blob/e560f5306928f680ce8f060520edefae4fa7de83/packages/vkui/src/components/CellButton/CellButton.module.css#L51-L57 <img width="390" alt="Корзина должна быть красная, даже если нету класса vkuiIcon у иконки" src="https://github.com/VKCOM/VKUI/assets/5443359/9fb2114e-266a-4168-8077-dc27eeba661b"> * Изменения - избавляемся от зависимости цвета от селекторов с .vkuiIcon классом - используем css-переменную `--vkui_internal--icon_color` которую задаём в `CellButton` и использем в `.SimpleCell__before` и `.SimpleCell__after` с фоллбэком на цвета SimpleCell. - это позволило также избавится от селекторов в `ImageBase` в случае когда `ImageBase` передается в `.CellButton `(что также было сломано, иконки внутри `ImageBase` в примере `CellButton` не принимали цвет заданный в `CellButton`).
|
✅ v5.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Выставление
colorявно в.SimpleCell__beforeперебивает цвет заданный в вышестоящем компоненте, таком какCellButton. В итоге влияет иконку без класса.vkuiIcon.VKUI/packages/vkui/src/components/CellButton/CellButton.module.css
Lines 51 to 57 in e560f53
Изменения
--vkui_internal--icon_colorкоторую задаём вCellButtonи использем в.SimpleCell__beforeи.SimpleCell__afterс фоллбэком на цвета SimpleCell.ImageBaseв случае когдаImageBaseпередается в.CellButton(что также было сломано, иконки внутриImageBaseв примереCellButtonне принимали цвет заданный вCellButton).