feature(ModalPage): Add height prop to ModalPage #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7a6bca0:
|
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit 7a6bca0 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5830 +/- ##
==========================================
+ Coverage 80.87% 81.13% +0.26%
==========================================
Files 300 300
Lines 9166 9193 +27
Branches 3122 3125 +3
==========================================
+ Hits 7413 7459 +46
+ Misses 1753 1734 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
To allow to specify fixed height of the modal
mendrew
force-pushed
the
mendrew/5712/feat/ModalPage/add-height
branch
from
4dc29e0 to
47463af
Compare
SevereCloud
reviewed
Sep 19, 2023
Style allows to pass undefined
SevereCloud
approved these changes
Sep 19, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Добавляем возможность устанавливать фиксированную высоту для ModalPage. * Изменения - добавлен новый проп `height`, который можно использовать как в мобильной версии так и в десктопной. - при использовании в мобильной версии `settlingHeight` будет высчитываться относительно заданного `height`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавляем возможность устанавливать фиксированную высоту для ModalPage.
Изменения
height, который можно использовать как в мобильной версии так и в десктопной.settlingHeightбудет высчитываться относительно заданногоheight.