Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActionSheetItem): add after #5828

Merged
merged 1 commit into from
Sep 19, 2023
Merged

feat(ActionSheetItem): add after #5828

merged 1 commit into from
Sep 19, 2023

Conversation

SevereCloud
Copy link
Contributor


  • [ ] Unit-тесты
  • [ ] e2e-тесты
  • [ ] Дизайн-ревью

Описание

Добавлено свойство after для ActionSheetItem

Изменения

Была вынесена Radio иконка как отдельный компонент, слегка пофиксил a11y.

Прокинул свойство after в нужное место

@SevereCloud SevereCloud requested a review from a team as a code owner September 19, 2023 07:42
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 316.45 KB (+0.07% 🔺)
JS (gzip) 96.54 KB (+0.06% 🔺)
JS (brotli) 79.96 KB (+0.07% 🔺)
JS import Div (tree shaking) 2.95 KB (0%)
CSS 275.77 KB (+0.01% 🔺)
CSS (gzip) 36 KB (-0.01% 🔽)
CSS (brotli) 28.5 KB (-0.03% 🔽)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 56eff7a:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 56eff7a

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (95e80a2) 80.85% compared to head (56eff7a) 80.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5828      +/-   ##
==========================================
+ Coverage   80.85%   80.87%   +0.01%     
==========================================
  Files         299      300       +1     
  Lines        9156     9164       +8     
  Branches     3118     3119       +1     
==========================================
+ Hits         7403     7411       +8     
  Misses       1753     1753              
Flag Coverage Δ
unittests 80.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...src/components/ActionSheetItem/ActionSheetItem.tsx 100.00% <100.00%> (ø)
...ents/ActionSheetItem/subcomponents/Radio/Radio.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Класс! 💯

@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 19, 2023
@SevereCloud SevereCloud merged commit 445c6d7 into master Sep 19, 2023
@SevereCloud SevereCloud deleted the SevereCloud/issue2017 branch September 19, 2023 09:16
vkcom-publisher pushed a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] after у ActionSheetItem
3 participants