Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Gradient): add new default mode #5827

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Sep 18, 2023


- [ ] Unit-тесты

  • e2e-тесты
  • Дизайн-ревью

Описание

Добавили новый mode=default для случая, когда в светлой теме используется white градиент, а в тёмной - оттенок серого (background_content)

Изменения

Добавила deprecated ненужных свойств, исправила немного стили, чтобы не было лишнего класса

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

size-limit report 📦

Path Size
JS 324.84 KB (+0.01% 🔺)
JS (gzip) 99.07 KB (+0.02% 🔺)
JS (brotli) 81.79 KB (-0.07% 🔽)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 255.19 KB (+0.05% 🔺)
CSS (gzip) 33.5 KB (+0.02% 🔺)
CSS (brotli) 27.16 KB (-0.02% 🔽)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b97c18e:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

👀 Docs deployed

Commit b97c18e

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1bc000a) 79.19% compared to head (b97c18e) 79.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5827   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files         304      304           
  Lines        9515     9520    +5     
  Branches     3217     3220    +3     
=======================================
+ Hits         7535     7539    +4     
- Misses       1980     1981    +1     
Flag Coverage Δ
unittests 79.19% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/vkui/src/components/Gradient/Gradient.tsx 90.90% <83.33%> (-9.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mendrew
mendrew previously approved these changes Sep 18, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

inomdzhon
inomdzhon previously approved these changes Sep 19, 2023
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 22, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 30, 2023
@BlackySoul BlackySoul removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 3, 2023
@BlackySoul BlackySoul dismissed stale reviews from inomdzhon and mendrew via f168a51 October 6, 2023 14:01
@BlackySoul BlackySoul force-pushed the feat/5218/Gradient_add_tokens branch from c62e5bb to f168a51 Compare October 6, 2023 14:01
mendrew
mendrew previously approved these changes Oct 6, 2023
@BlackySoul BlackySoul requested a review from a team October 13, 2023 16:26
Copy link

@Zaycevq Zaycevq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@BlackySoul BlackySoul merged commit 3c62191 into master Oct 18, 2023
@BlackySoul BlackySoul deleted the feat/5218/Gradient_add_tokens branch October 18, 2023 05:06
vkcom-publisher pushed a commit that referenced this pull request Oct 18, 2023
* feat(Gradient): add new default mode

* chore: add comment

* Add e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Научить Gradient менять цвет при смене Light / Dark темы
5 participants