Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tappable): add activated #5826

Merged
merged 2 commits into from
Sep 19, 2023
Merged

feat(Tappable): add activated #5826

merged 2 commits into from
Sep 19, 2023

Conversation

SevereCloud
Copy link
Contributor

  • [ ] Unit-тесты визуальное
  • e2e-тесты
  • [ ] Дизайн-ревью переключатель

Описание

Новое свойство для Tappable activated для переключения состояния

@SevereCloud SevereCloud requested a review from a team as a code owner September 18, 2023 15:15
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 18, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 18, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 165aa30:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023 •
edited
Loading

size-limit report 📦

Path Size
JS 316.3 KB (+0.02% 🔺)
JS (gzip) 96.51 KB (+0.02% 🔺)
JS (brotli) 80.05 KB (+0.18% 🔺)
JS import Div (tree shaking) 2.95 KB (0%)
CSS 275.77 KB (0%)
CSS (gzip) 36 KB (0%)
CSS (brotli) 28.51 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023 •
edited
Loading

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023 •
edited
Loading

👀 Docs deployed

Commit 165aa30

@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (95e80a2) 80.85% compared to head (165aa30) 80.85%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5826   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files         299      299           
  Lines        9156     9157    +1     
  Branches     3118     3119    +1     
=======================================
+ Hits         7403     7404    +1     
  Misses       1753     1753
Flag Coverage Δ
unittests 80.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/components/Tappable/Tappable.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mendrew
mendrew approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

inomdzhon
inomdzhon approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@SevereCloud SevereCloud merged commit de2126d into master Sep 19, 2023
@SevereCloud SevereCloud deleted the SevereCloud/issue5798 branch September 19, 2023 09:20
vkcom-publisher pushed a commit that referenced this pull request Sep 19, 2023
@SevereCloud @actions-user
feat(Tappable): add activated (#5826)
89de758 
* feat(Tappable): add `activated`
- closed #5798

* doc: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackySoul BlackySoul BlackySoul left review comments

@mendrew mendrew mendrew approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees
No one assigned
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Tappable]: Возможность управлять active состоянием Tappable извне
4 participants
@SevereCloud @mendrew @inomdzhon @BlackySoul