fix(ModalRoot): fix modal overlay #5805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d4bcebb:
|
e2e tests |
👀 Docs deployed
Commit d4bcebb |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5805 +/- ##
==========================================
+ Coverage 81.99% 82.02% +0.03%
==========================================
Files 298 298
Lines 9839 9846 +7
Branches 3115 3117 +2
==========================================
+ Hits 8067 8076 +9
+ Misses 1772 1770 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
BlackySoul
changed the title
BlackySoul
added
v5
eugpoloz
previously approved these changes
Sep 14, 2023
SevereCloud
previously approved these changes
Sep 14, 2023
inomdzhon
previously approved these changes
Sep 14, 2023
BlackySoul
dismissed stale reviews from inomdzhon, SevereCloud, and eugpoloz
via
3542e36
BlackySoul
force-pushed
the
fix/5740/ModalCard_fix_overlay_missing
branch
from
3542e36 to
d4bcebb
Compare
inomdzhon
approved these changes
Sep 15, 2023
mendrew
approved these changes
Sep 15, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 15, 2023
* fix(ModalRoot): fix overlay missing * feat(ModalRoot): add unit test for mask * fix(ModalRoot): add type and style safe func
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 15, 2023
* fix(ModalRoot): fix overlay missing * feat(ModalRoot): add unit test for mask * fix(ModalRoot): add type and style safe func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] e2e-тесты[ ] Дизайн-ревьюОписание
Для случая, когда модальные окна сменяются (
modal1 - null - modal2) достаточно быстро (в пределах длительности анимации закрытия), теряли подложку у модального окна (она оставалась вopacity: 0, а при появлении нового окна (из состоянияnull) мы всегда полагались на то, что компонент с подложкой будет замаунчен заново).Изменения
Теперь в
entering-фазе всегда проставляем подложкеopacity: 1.Для десктопной версии завернула изменение стилей в
requestAnimationFrame, чтобы сохранить очередность событий