Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ImageBase): Clickable #5803

Merged
merged 2 commits into from
Sep 17, 2023
Merged

feat(ImageBase): Clickable #5803

merged 2 commits into from
Sep 17, 2023

Conversation

SevereCloud
Copy link
Contributor

  • Unit-тесты
  • [ ] e2e-тесты (функциональное поведение)
  • [ ] Дизайн-ревью (функциональное поведение)

Описание

Даем возможность кликабельности изображение

Изменения

Добавил новый внутренний компонент Clickable для правильной работы a11y. В будущем он должен заменить Tappable (#3599 #1443)

@SevereCloud SevereCloud requested a review from a team as a code owner September 14, 2023 12:32
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 14, 2023
@SevereCloud SevereCloud self-assigned this Sep 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited
Loading

size-limit report 📦

Path Size
JS 319.1 KB (+0.27% 🔺)
JS (gzip) 96.92 KB (+0.26% 🔺)
JS (brotli) 80.27 KB (+0.17% 🔺)
JS import Div (tree shaking) 2.95 KB (0%)
CSS 275.74 KB (+0.04% 🔺)
CSS (gzip) 36.01 KB (+0.08% 🔺)
CSS (brotli) 28.54 KB (+0.12% 🔺)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 14, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ecd690:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited
Loading

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited
Loading

👀 Docs deployed

Commit 7ecd690

@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 97.05% and project coverage change: +0.05% 🎉

Comparison is base (08b3976) 80.68% compared to head (7ecd690) 80.74%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5803      +/-   ##
==========================================
+ Coverage   80.68%   80.74%   +0.05%     
==========================================
  Files         298      299       +1     
  Lines        9133     9165      +32     
  Branches     3110     3120      +10     
==========================================
+ Hits         7369     7400      +31     
- Misses       1764     1765       +1
Flag Coverage Δ
unittests 80.74% <97.05%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ckages/vkui/src/components/Clickable/Clickable.tsx 96.96% <96.96%> (ø)
...ckages/vkui/src/components/ImageBase/ImageBase.tsx 92.45% <100.00%> (-0.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

inomdzhon
inomdzhon previously approved these changes Sep 15, 2023
View reviewed changes
mendrew
mendrew previously approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отличная работа! 💯

@SevereCloud
feat(ImageBase): Clickable
ce3cd44 
Даем возможность кликабельности изображение
@SevereCloud
fix: add NonClickable && RealClickable
7ecd690
@SevereCloud SevereCloud dismissed stale reviews from mendrew and inomdzhon via 7ecd690 September 15, 2023 18:16
@SevereCloud SevereCloud force-pushed the SevereCloud/feat/ImageBase/Clickable branch from b2fca01 to 7ecd690 Compare September 15, 2023 18:16
@SevereCloud
Copy link
Contributor Author

фикс конфликтов

@SevereCloud SevereCloud merged commit 62b2c1d into master Sep 17, 2023
@SevereCloud SevereCloud deleted the SevereCloud/feat/ImageBase/Clickable branch September 17, 2023 14:04
vkcom-publisher pushed a commit that referenced this pull request Sep 17, 2023
@SevereCloud @actions-user
feat(ImageBase): Clickable (#5803)
eb477cc
@SevereCloud SevereCloud added this to the v5.9.0 milestone Sep 18, 2023
@eugpoloz eugpoloz mentioned this pull request Sep 20, 2023
Closed
@vkcom-publisher
Copy link
Contributor

✅ v5.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorprnn egorprnn egorprnn left review comments

@mendrew mendrew mendrew approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@SevereCloud SevereCloud

Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
VKUI
Archived in project
Milestone
v5.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SevereCloud @vkcom-publisher @mendrew @inomdzhon @egorprnn