Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Group): header margin #5799

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

SevereCloud
Copy link
Contributor

  • [ ] Unit-тесты (css)
  • e2e-тесты
  • [ ] Дизайн-ревью (визуальное исправление)

Описание

Делаем для свойства header правильное расположение

Изменения

Все что передается в header будет визуально смещено вверх в зависимости от логики(карточка или не первая плашка)

@SevereCloud SevereCloud requested a review from a team as a code owner September 13, 2023 13:21
@SevereCloud SevereCloud added ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Sep 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

size-limit report 📦

Path Size
JS 346.16 KB (+0.02% 🔺)
JS (gzip) 103.23 KB (+0.01% 🔺)
JS (brotli) 84.36 KB (+0.05% 🔺)
JS import Div (tree shaking) 3.04 KB (0%)
CSS 278.72 KB (+0.15% 🔺)
CSS (gzip) 36.3 KB (+0.09% 🔺)
CSS (brotli) 28.73 KB (0%)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 294f147:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

👀 Docs deployed

Commit 294f147

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c965048) 81.99% compared to head (294f147) 81.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5799   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files         298      298           
  Lines        9839     9840    +1     
  Branches     3115     3116    +1     
=======================================
+ Hits         8067     8068    +1     
  Misses       1772     1772           
Flag Coverage Δ
unittests 81.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/components/Group/Group.tsx 87.50% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо 👍

@SevereCloud SevereCloud modified the milestones: v5.9.0, v5.8.2 Sep 15, 2023
@SevereCloud SevereCloud merged commit 0ffa002 into master Sep 15, 2023
@SevereCloud SevereCloud deleted the SevereCloud/fix/Group/header-margin branch September 15, 2023 13:43
vkcom-publisher pushed a commit that referenced this pull request Sep 15, 2023
vkcom-publisher pushed a commit that referenced this pull request Sep 15, 2023
@SevereCloud SevereCloud mentioned this pull request Sep 18, 2023
@SevereCloud SevereCloud self-assigned this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants